Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing async fetch-meta-tags #69515

Merged
merged 1 commit into from May 6, 2024

Conversation

silversonicaxel
Copy link
Contributor

@silversonicaxel silversonicaxel commented May 4, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 4, 2024

@silversonicaxel Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69515,
  "author": "silversonicaxel",
  "headCommitOid": "628ac8dcdb41f2dfd6066ca75a4acc7a3692737b",
  "mergeBaseOid": "1c01676bd56522b1eb13f7e4e0a2415773c535a6",
  "lastPushDate": "2024-05-04T08:24:09.000Z",
  "lastActivityDate": "2024-05-06T07:23:33.000Z",
  "mergeOfferDate": "2024-05-05T06:57:50.000Z",
  "mergeRequestDate": "2024-05-06T07:23:33.000Z",
  "mergeRequestUser": "silversonicaxel",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "fetch-meta-tags",
      "kind": "edit",
      "files": [
        {
          "path": "types/fetch-meta-tags/fetch-meta-tags-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/fetch-meta-tags/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "silversonicaxel"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-05T06:57:10.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2094076762,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels May 4, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 4, 2024
@typescript-bot
Copy link
Contributor

🔔 @silversonicaxel — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@DangerBotOSS
Copy link

DangerBotOSS commented May 4, 2024

Formatting

The following files are not formatted:

  1. types/fetch-meta-tags/fetch-meta-tags-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 628ac8d

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 5, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 5, 2024
@typescript-bot
Copy link
Contributor

@silversonicaxel: Everything looks good here. I am ready to merge this PR (at 628ac8d) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@silversonicaxel
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 6, 2024
@typescript-bot typescript-bot merged commit b97205a into DefinitelyTyped:master May 6, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants