Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draco3d: Add definitions for the metadata API #69505

Merged
merged 2 commits into from May 14, 2024

Conversation

kbongort
Copy link
Contributor

@kbongort kbongort commented May 3, 2024

  • Adds definitions for the metadata API, and a couple other missing methods.
  • Standardizes style for method declarations throughout the file.

Checklist:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: decoder_webidl_wrapper.h, encoder_webidl_wrapper.h
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json. N/A: These APIs have existed for several years

@typescript-bot
Copy link
Contributor

typescript-bot commented May 3, 2024

@kbongort Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69505,
  "author": "kbongort",
  "headCommitOid": "014f2b121a29079b8ebee625dde8301a77a5a541",
  "mergeBaseOid": "01e693875c833ce161a11a7f1e063f9d0533071e",
  "lastPushDate": "2024-05-03T05:51:32.000Z",
  "lastActivityDate": "2024-05-14T14:58:37.000Z",
  "mergeOfferDate": "2024-05-14T13:16:05.000Z",
  "mergeRequestDate": "2024-05-14T14:58:37.000Z",
  "mergeRequestUser": "donmccurdy",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "draco3d",
      "kind": "edit",
      "files": [
        {
          "path": "types/draco3d/draco3d-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/draco3d/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "donmccurdy",
        "horizon0514"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "donmccurdy",
      "date": "2024-05-14T13:15:27.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2092351148,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label May 3, 2024
@typescript-bot
Copy link
Contributor

🔔 @donmccurdy @horizon0514 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 3, 2024
@typescript-bot
Copy link
Contributor

Re-ping @donmccurdy, @horizon0514:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 14, 2024
Copy link
Contributor

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbongort thank you!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 14, 2024
@typescript-bot
Copy link
Contributor

@kbongort: Everything looks good here. I am ready to merge this PR (at 014f2b1) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@donmccurdy, @horizon0514: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 14, 2024
@donmccurdy
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 14, 2024
@typescript-bot typescript-bot merged commit 83a2d25 into DefinitelyTyped:master May 14, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants