New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added @lambda-lambda-lambda/cli types #69502
Conversation
@nuxy Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69502,
"author": "nuxy",
"headCommitOid": "ff4dd4c23389f97fcc4690fb47dd68ae1b4bb4fc",
"mergeBaseOid": "4354a1088a2881bf6613b98c84d18e614f08705e",
"lastPushDate": "2024-05-02T20:53:34.000Z",
"lastActivityDate": "2024-05-06T17:09:41.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "lambda-lambda-lambda__cli",
"kind": "add",
"files": [
{
"path": "types/lambda-lambda-lambda__cli/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/lambda-lambda-lambda__cli/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/lambda-lambda-lambda__cli/index.d.ts",
"kind": "definition"
},
{
"path": "types/lambda-lambda-lambda__cli/lambda-lambda-lambda__cli-tests.ts",
"kind": "test"
},
{
"path": "types/lambda-lambda-lambda__cli/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/lambda-lambda-lambda__cli/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"nuxy"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2091542577,
"ciResult": "pass"
} |
🔔 @nuxy — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
hey, the module repo contains already TS files, what's the status?
|
The types in question are to be removed post PR approval/release. |
I believe TS/TD team encourages everyone to stick to handbook (your code contains .d.ts? ship it with our code): |
The motivation behind this was to expose CLI types to third-party integrated scripts (non NPM) without having to install the main package since it comes with a lot of baggage (e.g. templates, images, etc). That said, after revaluating my options I'm going to self-host the types in it's own repo. |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.