New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@types/selectize] Add missing silent
parameter
#69499
base: master
Are you sure you want to change the base?
Conversation
@codershiba Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69499,
"author": "codershiba",
"headCommitOid": "ee27f013c03ff0ec89b7bd24c26f55a3928e71f0",
"mergeBaseOid": "11ab9a78ca6b1bf454b895aa874ca3f4b203b198",
"lastPushDate": "2024-05-02T11:45:23.000Z",
"lastActivityDate": "2024-05-16T16:44:46.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "selectize",
"kind": "edit",
"files": [
{
"path": "types/selectize/index.d.ts",
"kind": "definition"
}
],
"owners": [
"adidahiya",
"naBausch"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "sandersn",
"date": "2024-05-16T16:44:46.000Z"
}
],
"mainBotCommentID": 2090301338,
"ciResult": "pass"
} |
Hey @codershiba, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select |
The DT package is at |
Re-ping @adidahiya, @naBausch: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes so the bot knows the current status.
@codershiba One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Fixes #69495
Fixes #69428
Please fill in this template.
pnpm test selectize
.If changing an existing definition:
package.json
.