New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] Export TestContext and SuiteContext on v16-v18-v2x #69497
[node] Export TestContext and SuiteContext on v16-v18-v2x #69497
Conversation
Signed-off-by: Lucas Santos <[email protected]>
Signed-off-by: Lucas Santos <[email protected]>
Signed-off-by: Lucas Santos <[email protected]>
@khaosdoctor Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69497,
"author": "khaosdoctor",
"headCommitOid": "7e3f085ef6d8470681cd3ca6d95619ca0276cb57",
"mergeBaseOid": "13c2de2b611c93311325c51625a95dea6a08881f",
"lastPushDate": "2024-05-02T09:40:42.000Z",
"lastActivityDate": "2024-05-06T17:03:51.000Z",
"mergeOfferDate": "2024-05-06T16:59:24.000Z",
"mergeRequestDate": "2024-05-06T17:03:51.000Z",
"mergeRequestUser": "khaosdoctor",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v16/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v16/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v18/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v18/test/test.ts",
"kind": "test"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2024-05-06T16:58:45.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "Semigradsky",
"date": "2024-05-06T08:05:47.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "codershiba",
"date": "2024-05-05T14:35:51.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2090030855,
"ciResult": "pass"
} |
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
Signed-off-by: Lucas Santos <[email protected]>
Signed-off-by: Lucas Santos <[email protected]>
Co-authored-by: codershiba <[email protected]>
@codershiba Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@khaosdoctor: Everything looks good here. I am ready to merge this PR (at 7e3f085) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky: you can do this too.) |
Ready to merge |
I think this is a useful change on its own, but it will make our migration from Brittle to `node:test` easier because [`TestContext` is now exported][0], which we'll need. [0]: DefinitelyTyped/DefinitelyTyped#69497
I think this is a useful change on its own, but it will make our migration from Brittle to `node:test` easier because [`TestContext` is now exported][0], which we'll need. [0]: DefinitelyTyped/DefinitelyTyped#69497
pnpm test <package to test>
. On this one I had V8 stack traces and memory issues, will try to let the bot run the testsSelect one of these and delete the others:
URLs: