Steamutil: Do not raise error in get_steam_vdf_compat_tool_mapping #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the error message and return
{}instead of raising aKeyErroringet_steam_vdf_compat_tool_mapping.If the
Value/valuekey does not exist for some reason, ProtonUp-Qt will crash on start.Returning
{}prevents the crash and the functions callingget_steam_vdf_compat_tool_mappingshould handle that case (although they might not work as expected).(Update to
get_steam_vdf_compat_tool_mappingwhich was introduced in #227)Also, indicate which function prints the error message if the text is the same otherwise.