Use steam and vdf dependency by Solstice Game Studios

[DavidoTek]

Fix #415

Use steam and vdf dependency by Solstice Game Studios:

• https://github.com/solsticegamestudios/vdf (master branch)
• https://github.com/solsticegamestudios/steam (master branch)

[sonic2kk]

Out of interest, do we want to point to the master branch, or do we want to point to specific tags? For example the v3.5 tag.

We can point to the tag with, for example git+https://github.com/solsticegamestudios/[email protected].

This can help with consistency and making sure the same version is used when, i.e. the Flatpak is built, the AppImage is built, and for other packages. This will also make bumping the dependency version easier.

But maybe you already considered this and there's a reason to point directly to master? I'm not used to maintaining dependencies so there might be a good reason why tags weren't used 😄

[sonic2kk]

I left a comment on the AUR packages for ProtonUp-Qt, protonup-qt and protonup-qt-bin, to let them know that we are using a fork of these dependencies now. It probably doesn't apply as much to protonup-qt-bin but I wanted to let them know just in case (not a package maintainer, don't want to risk making faulty assumptions).

[DavidoTek]

Out of interest, do we want to point to the master branch, or do we want to point to specific tags? For example the v3.5 tag.
We can point to the tag with, for example git+https://github.com/solsticegamestudios/[email protected].

Good point.
I thought about that too. Our convention until now was to only specify a minimum version in the requirements.txt (e.g., requests>=2.27.0). I think I originally put it in because people are installing it directly on the system (AUR, Pacstall, dev build without venv).
This also means we do not need to worry about updating the dependencies. But I get the point, if there are changes breaking compatibility (like suddently requiring the mapper=dict parameter), they will appear without notice and it can be harder to track the issue as there can be inconsistencies between the Flatpak and AppImage build.

In case something like this happens, we may consider changing it from master to a fixed version. I think the risk of waiting for such an event is low as existing builds are not affected.

EDIT: Okay, I guess it is not guaranteed that the code on master is stable. Let's see.

I left a comment on the AUR packages for ProtonUp-Qt, protonup-qt and protonup-qt-bin, to let them know that we are using a fork of these dependencies now.

Great, thanks.

I just released a new version (v2.10.0 🎉), but apparently the new AppImage build (#359, #382, #392, #430) is still broken. AUR can use it just fine though and Flatpak too (there just isn't any "AppImage Beta Testing" right now).