Slim 4 support route params #56
Conversation
Please update for slim 4 support and also respect version to 2 Thanks,
|
Need to update php unit tests |
|
Hi @M-Shahbaz. Are you still working on this PR? |
|
@DavidePastore updated and All checks have passed. |
There was a problem hiding this comment.
Hi @M-Shahbaz, thanks for your effort on this PR. I reviewed it. Please, let me know if you need further explanations.
| ]; | ||
|
|
||
| /** | ||
| * The translator to use for the exception message. | ||
| * | ||
| * @var callable | ||
| * @var array |
There was a problem hiding this comment.
Why is $translator defined as an array?
There was a problem hiding this comment.
$exception->setParam('translator', $this->translator); callable setParam not available in v2.0+ of Respect/Validation
Converted to custom messages using array: https://github.com/Respect/Validation/blob/master/docs/feature-guide.md#custom-messages
| @@ -70,7 +75,7 @@ class Validation | |||
| * Create new Validator service provider. | |||
| * | |||
| * @param null|array|ArrayAccess $validators | |||
| * @param null|callable $translator | |||
| * @param null|array $translator | |||
There was a problem hiding this comment.
Why is $translator defined as an array?
There was a problem hiding this comment.
$exception->setParam('translator', $this->translator); callable setParam not available in v2.0+ of Respect/Validation
Converted to custom messages using array: https://github.com/Respect/Validation/blob/master/docs/feature-guide.md#custom-messages
There was a problem hiding this comment.
You can now translate messages using the withTranslator method.
| use Respect\Validation\Validator as v; | ||
|
|
||
| class ValidationTest extends \PHPUnit_Framework_TestCase | ||
| class ValidationTest extends TestCase |
There was a problem hiding this comment.
This file is missing a lot of tests that was previously available. Why were they removed?
There was a problem hiding this comment.
I was only able to make these tests work with Slim 4. Maybe you can add more tests as we now have Slim 4 bootstrap.
There was a problem hiding this comment.
Unfortunately these tests are important and should be part of the middleware.
No description provided.