Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollResize - Fix max-height as the size of the table #603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rodriformiga
Copy link

If the table height is smaller than the avaliable height, the size will be the table size. For example if I filter zero records on serch field.

Are you happy for it to be included and distributed under the MIT license? ✔️/❌

If the table height is smaller than the avaliable height, the size will be the table size. For example if I filter zero records on serch field.
@rodriformiga rodriformiga changed the title Fix max-height as the size of the table ScrollResize - Fix max-height as the size of the table Oct 8, 2024
@AllanJard
Copy link
Contributor

Hi - thanks for the PR. Does this still work if you filter down and then delete the filter? Or does it leave the viewport in its reduced state?

I think there are cases where the current behaviour is desirable (e.g. this one), but I can see that it might not be what is always wanted.

@rodriformiga
Copy link
Author

rodriformiga commented Oct 14, 2024

Hi Allan

Yes, it still work when you delete the filter. In my case, i do not have the footer element, so, in the botton of the page only remains the info page - a little strange with a big gap..
And I use compact and cell-border i table classes, so thats why I did this change.
before

And of course, to keep both behavior, may we can add an option to control this.

@AllanJard
Copy link
Contributor

Yeah, its a good point. There was a plugin a while back that would fill in fake rows to take up the space and make it a bit less empty.

I think I'll leave this one open if that is okay, and see if it can garner any feedback from others who might be using or looking for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants