Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp: Remove remaining references of dd-opentracing-cpp #23258

Merged
merged 4 commits into from
May 22, 2024

Conversation

dmehala
Copy link
Contributor

@dmehala dmehala commented May 19, 2024

What does this PR do? What is the motivation?

This PR removes remaining references of dd-opentracing-cpp in fr and en.

Merge instructions

  • Please merge after reviewing

Additional notes

I noticed that the C++ documentation translated into Japanese and Korean hasn't been updated. What is the process for translating these documents?

@github-actions github-actions bot added the Guide Content impacting a guide label May 19, 2024
@dmehala dmehala changed the title Update c++ documentation cpp: Remove remaining references to dd-opentracing-cpp May 21, 2024
@dmehala dmehala requested a review from bm1549 May 21, 2024 08:22
@dmehala dmehala marked this pull request as ready for review May 21, 2024 08:23
@dmehala dmehala requested a review from a team as a code owner May 21, 2024 08:23
@dmehala dmehala changed the title cpp: Remove remaining references to dd-opentracing-cpp cpp: Remove remaining references of dd-opentracing-cpp May 21, 2024
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dmehala, thank you for your PR! I made one suggestion so that the variables appear as code instead of being enclosed by backticks. Thank you for editing the French version, but our translators will handle it so I would ask you to discard your changes in /fr/, because they'll be overwritten by our Translation pipeline anyway. To answer your question, any change made to the English version gets translated by Transifex a few days or weeks after, but sometimes they get a backlog. I will ask them to prioritize these files in Japanese and Korean!

content/en/tracing/trace_collection/proxy_setup/_index.md Outdated Show resolved Hide resolved
@rtrieu
Copy link
Contributor

rtrieu commented May 21, 2024

@dmehala FYI, I have prioritized the translation of this file.

Screenshot 2024-05-21 at 10 39 42 AM

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for these updates!

@rtrieu rtrieu merged commit 0a3e340 into master May 22, 2024
13 checks passed
@rtrieu rtrieu deleted the dmehala/moar-cpp-updates branch May 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants