Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run dogfood tests on every pull request #9273

Merged
merged 36 commits into from
May 24, 2024
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented May 15, 2024

This change causes pull request CI to trigger runs of an internal Datadog CI suite "dogweb" using the PR HEAD version of dd-trace-py. These triggered runs only appear in the github CI job listing once they have finished (success or fail).

Dogweb tests are run on a non-prod branch because there's ongoing review of the pull request implementing this capability: https://github.com/DataDog/dogweb/pull/119182

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler requested a review from a team as a code owner May 15, 2024 17:03
@emmettbutler emmettbutler marked this pull request as draft May 15, 2024 17:03
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/ci-dogfood
Commit report: 3898764
Test service: dd-trace-py

❌ 14 Failed (0 Known Flaky), 149551 Passed, 23255 Skipped, 7h 22m 25.92s Total duration (2h 26m 11.49s time saved)
❄️ 31 New Flaky

❌ Failed Tests (14)

This report shows up to 5 failed tests.

  • test_django_iast_disabled_full_sqli_http_path_parameter - test_django_appsec_iast.py - Details

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_django_iast_enabled_full_sqli_http_path_parameter - test_django_appsec_iast.py - Details

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_django_tainted_iast_disabled_sqli_http_body - test_django_appsec_iast.py - Details

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_django_tainted_iast_disabled_sqli_http_cookies_name - test_django_appsec_iast.py - Details

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_django_tainted_iast_disabled_sqli_http_cookies_value - test_django_appsec_iast.py - Details

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    

New Flaky Tests (31)

  • test_and_emit_get_version - test_asyncpg_patch.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.asyncpg.test_asyncpg_patch.TestAsyncpgPatch.test_and_emit_get_version" Failed
    
  • test_analytics_global_off_integration_default - test_django.py - Last Failure

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_cached_view - test_django.py - Last Failure

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_connection - test_django.py - Last Failure

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    
  • test_connections_patched - test_django.py - Last Failure

    Expand for error
     connection failed: Connection refused
     	Is the server running on host "127.0.0.1" and accepting
     	TCP/IP connections on port 5432?
    

@pr-commenter
Copy link

pr-commenter bot commented May 15, 2024

Benchmarks

Benchmark execution time: 2024-05-23 19:27:12

Comparing candidate commit 24699c5 in PR branch emmett.butler/ci-dogfood with baseline commit 1cb3487 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@emmettbutler emmettbutler changed the title stub for running dogfood tests on pull requests ci: run dogfood tests on every pull request May 16, 2024
@emmettbutler
Copy link
Collaborator Author

suggested alternate approach:

stages:
  - test
  - validate

dogweb-pipeline:
  stage: test
  trigger:
    project: DataDog/dogweb
    strategy: depend

validate-dogweb:
  stage: validate
  needs:
    - dogweb-pipeline

notify-dogweb-failure:
  stage: validate
  when: on_failure

@emmettbutler emmettbutler marked this pull request as ready for review May 24, 2024 13:14
.gitlab/dogfood.yml Show resolved Hide resolved
.gitlab/dogfood.yml Show resolved Hide resolved
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 24, 2024
@brettlangdon brettlangdon enabled auto-merge (squash) May 24, 2024 14:14
@brettlangdon brettlangdon merged commit 6cfc798 into main May 24, 2024
84 checks passed
@brettlangdon brettlangdon deleted the emmett.butler/ci-dogfood branch May 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants