[STAL-1960] Add tree-sitter query wrapper #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
As we refactor the JS runtime, we want to be able to efficiently send data between v8 and Rust.
What is your solution?
This PR is part of a larger chain of PRs. However:
tree_sitter::Query
to provide a better API for our use case:tree_sitter::Node
with au32
id. Because this all starts with a tree-sitter query, which "captures" nodes, we implement a generic struct that will allow us to cleanly implement this (e.g.TSCaptureContent<tree_sitter::Node>
will be transformed intoTSCaptureContent<NodeId>
)Alternatives considered
What the reviewer should know
tree_sitter::QueryCursor
for every query, instead of allocating it and dropping it for every file/rule combo.