New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] add kill action to windows #25513
Conversation
Regression DetectorRegression Detector ResultsRun ID: 14f3f544-b77b-4780-9a49-8ab0bb6a9182 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
❌ | file_to_blackhole | % cpu utilization | +117.01 | [+107.18, +126.83] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
❌ | file_to_blackhole | % cpu utilization | +117.01 | [+107.18, +126.83] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +10.43 | [-11.65, +32.50] |
➖ | basic_py_check | % cpu utilization | +0.65 | [-1.77, +3.06] |
➖ | file_tree | memory utilization | +0.27 | [+0.16, +0.37] |
➖ | idle | memory utilization | +0.15 | [+0.11, +0.19] |
➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.25, +0.47] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.01] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.21, +0.20] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.02] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.17 | [-3.99, +1.66] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.27 | [-7.05, +2.51] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
4b5b156
to
3a17fc9
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34165736 --os-family=ubuntu |
3a17fc9
to
f1b09ef
Compare
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 51m) Use |
❌ MergeQueue Build pipeline has failing jobs for a83fa43 Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 26m) Use |
❌ MergeQueue Build pipeline has failing jobs for 5b8a48a Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
Adds api (not called anywhere by this PR) to kill a process by its pid. Testing instructions will be included in the PR which consumes this API. (cherry picked from commit 79c355d)
f1b09ef
to
7a4bead
Compare
7a4bead
to
4d8481b
Compare
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 26m) Use |
What does this PR do?
Add the kill action support. Currently only one signal is supported : SIGKILL
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes