Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] add kill action to windows #25513

Merged
merged 2 commits into from May 14, 2024
Merged

[CWS] add kill action to windows #25513

merged 2 commits into from May 14, 2024

Conversation

safchain
Copy link
Contributor

What does this PR do?

Add the kill action support. Currently only one signal is supported : SIGKILL

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Regression Detector

Regression Detector Results

Run ID: 14f3f544-b77b-4780-9a49-8ab0bb6a9182
Baseline: a5f7a7f
Comparison: 4d8481b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +117.01 [+107.18, +126.83]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +117.01 [+107.18, +126.83]
tcp_syslog_to_blackhole ingress throughput +10.43 [-11.65, +32.50]
basic_py_check % cpu utilization +0.65 [-1.77, +3.06]
file_tree memory utilization +0.27 [+0.16, +0.37]
idle memory utilization +0.15 [+0.11, +0.19]
otel_to_otel_logs ingress throughput +0.11 [-0.25, +0.47]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.01]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02]
uds_dogstatsd_to_api_cpu % cpu utilization -1.17 [-3.99, +1.66]
pycheck_1000_100byte_tags % cpu utilization -2.27 [-7.05, +2.51]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@safchain safchain marked this pull request as ready for review May 13, 2024 07:44
@safchain safchain requested review from a team as code owners May 13, 2024 07:44
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34165736 --os-family=ubuntu

@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 51m)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

❌ MergeQueue

Build pipeline has failing jobs for a83fa43

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #devflow with those details!

@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

❌ MergeQueue

Build pipeline has failing jobs for 5b8a48a

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #devflow with those details!

Adds api (not called anywhere by this PR) to kill a process by its pid.

Testing instructions will be included in the PR which consumes this API.

(cherry picked from commit 79c355d)
@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 14, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 7994f55 into main May 14, 2024
214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/killwin branch May 14, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants