[ASCII-1613] Split dogstatsd/replay into new component hierarchy
#25512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgimalac
added
changelog/no-changelog
team/agent-metrics-logs
component framework
qa/done
Go Package Import DifferencesBaseline: 442605d
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34820319 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: e5185d20-8748-432a-816a-28cc40e629d6 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +11.65 | [-10.54, +33.84] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.37 | [-0.54, +5.27] |
| ➖ | basic_py_check | % cpu utilization | +1.38 | [-1.26, +4.02] |
| ➖ | idle | memory utilization | +0.36 | [+0.32, +0.40] |
| ➖ | file_tree | memory utilization | +0.07 | [-0.06, +0.19] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.03 | [-0.02, +0.07] |
| ➖ | otel_to_otel_logs | ingress throughput | +0.02 | [-0.35, +0.39] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
| ➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
| ➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.77 | [-5.25, +3.71] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
5ec9800
to
42eaaff
Compare
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
42eaaff
to
7636d9b
Compare
hush-hush
requested changes
May 15, 2024
GustavoCaso
reviewed
May 21, 2024
GustavoCaso
reviewed
May 21, 2024
GustavoCaso
reviewed
May 21, 2024
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
1532005
to
793d284
Compare
…/dsd-replay-split
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25512 +/- ##
===========================================
+ Coverage 45.01% 47.73% +2.72%
===========================================
Files 2314 242 -2072
Lines 266339 21285 -245054
===========================================
- Hits 119885 10160 -109725
+ Misses 136896 10614 -126282
+ Partials 9558 511 -9047
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GustavoCaso
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split
comp/dogstats/replayinto multiple packages for the component, fx, and implementations.Motivation
Removing some dependencies from serverless.
When everything is in the same package you get everything at once whether you want it or not.
Additional Notes
This PR should be easier to review commit by commit:
Remaining commits are small and address review comments.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
QA is handled in #25442