[windows][cws][wkint-494] fix long, slow memory leak in CWS due to missed notifi… #25493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cations. Change file and registry cache to (configurable size) LRU. Prevents missing messages from causing runaway memory leak. While it won't prevent the messages from being lost, puts an upper bound on our memory consumption and prevents the leak.
derekwbrown
added
team/agent-security
team/windows-kernel-integrations
and removed
component/system-probe
labels
derekwbrown
added
changelog/no-changelog
qa/done
derekwbrown
changed the title
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34200770 --os-family=ubuntu |
paulcacheux
approved these changes
May 13, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 23m) Use |
derekwbrown
added a commit
that referenced
this pull request
May 16, 2024
…ssed notifi… (#25493) * [windows][cws] fix long, slow memory leak in CWS due to missed notifications. Change file and registry cache to (configurable size) LRU. Prevents missing messages from causing runaway memory leak. While it won't prevent the messages from being lost, puts an upper bound on our memory consumption and prevents the leak. * fix incorrect key access; discovered in auto-tests
derekwbrown
added a commit
that referenced
this pull request
May 16, 2024
Backport using LRU cache to store file & registry path names. Limits the amount of memory consumed when notifications are missed. Also adds, in addition to original PR, stats to count when this occurs. Original PR: #25493
dd-mergequeue bot
pushed a commit
that referenced
this pull request
May 16, 2024
* [windows][cws][wkint-494] fix long, slow memory leak in CWS due to missed notifi… (#25493) * [windows][cws] fix long, slow memory leak in CWS due to missed notifications. Change file and registry cache to (configurable size) LRU. Prevents missing messages from causing runaway memory leak. While it won't prevent the messages from being lost, puts an upper bound on our memory consumption and prevents the leak. * fix incorrect key access; discovered in auto-tests * [windows][cws][wkint-494] Backport LRU cache. Backport using LRU cache to store file & registry path names. Limits the amount of memory consumed when notifications are missed. Also adds, in addition to original PR, stats to count when this occurs. Original PR: #25493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cations.
Change file and registry cache to (configurable size) LRU. Prevents missing messages from causing runaway memory leak.
While it won't prevent the messages from being lost, puts an upper bound on our memory consumption and prevents the leak.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
There is some possibility that using an LRU cache, if not sized properly, will cause us to miss additional messages
because the filename was prematurely expired from the cache.
Describe how to test/QA your changes
Run it in the wkit load environment.