Minnow update #441
Minnow update #441
Conversation
filipleple
force-pushed
the
minnow-update
branch
3 times, most recently
from
3755fc3 to
9d4148a
Compare
| ${FIRMWARE_NUMBER_VERIFICATION}= ${TRUE} | ||
| ${PRODUCT_NAME_VERIFICATION}= ${TRUE} | ||
| ${UEFI_SHELL_SUPPORT}= ${TRUE} | ||
| ${EXTERNAL_HDMI_DISPLAY_SUPPORT}= ${FALSE} |
There was a problem hiding this comment.
There is a HDMI on this board, so we should test it
There was a problem hiding this comment.
yes, commit fixed, but still it is FALSE, why? Unresolving
| ${DASHARO_NETWORKING_MENU_SUPPORT}= ${TRUE} | ||
| ${DASHARO_INTEL_ME_MENU_SUPPORT}= ${TRUE} | ||
| ${DASHARO_CHIPSET_MENU_SUPPORT}= ${TRUE} | ||
| ${MEASURED_BOOT_SUPPORT}= ${TRUE} |
There was a problem hiding this comment.
No measured boot yet, as there is no TPM support
| ${DASHARO_INTEL_ME_MENU_SUPPORT}= ${TRUE} | ||
| ${DASHARO_CHIPSET_MENU_SUPPORT}= ${TRUE} |
There was a problem hiding this comment.
These two are not enabled in the firmware
There was a problem hiding this comment.
Why is it showing TRUE again? Unresolving
| @@ -47,5 +93,5 @@ Power On | |||
| Rte Power Off | |||
There was a problem hiding this comment.
What does Rte Power Off do? I can't find the definition in the tree.
There was a problem hiding this comment.
https://github.com/Dasharo/osfv-scripts/blob/main/osfv_cli/src/osfv/rf/rte_robot.py#L125 - the same as osfv_cli rte pwr off
There was a problem hiding this comment.
I don't see any reason why we do Power Off if a couple of lines later we do Relay On. it is pointless.
| @@ -23,7 +23,7 @@ Get CPU Frequency MIN | |||
|
|
|||
| Get CPU Temperature CURRENT | |||
| [Documentation] Get current CPU temperature. | |||
| ${temperature}= Execute Command In Terminal sensors 2>/dev/null | awk -F '[+°]' '/Package id 0:/ {printf $2}' | |||
| ${temperature}= Execute Command In Terminal sensors 2>/dev/null | awk -F '[+°]' '/Core 0:/ {printf $2}' | |||
There was a problem hiding this comment.
So in order to fix the test for Minnow you will break all other platforms?
Why not just simply read the output for sensors and grep by Package id 0:, if not found use Core 0: else use Package id 0:?
@macpijan do we have any control over such methodology of work causing endless loops of broken tests?
There was a problem hiding this comment.
problem addressed: 917f329
|
@wiktormowinski this commit be94c3c reverted all the changes that I requested and @filipleple applied. What is going on? |
|
maybe i had an older version or something |
wiktormowinski
force-pushed
the
minnow-update
branch
from
c922a9d to
917f329
Compare
wiktormowinski
force-pushed
the
minnow-update
branch
4 times, most recently
from
001d010 to
a2c1b1f
Compare
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Wiktor Mowinski <[email protected]>
Signed-off-by: Wiktor Mowinski <[email protected]>
wiktormowinski
force-pushed
the
minnow-update
branch
from
a2c1b1f to
66c6d63
Compare
No description provided.