dts-subscription.sh: shellcheck fixes #51
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed most
info
warnings from shellcheck insidedts-subscription.sh
script. As we are only using warning and error in our pre-commit a lot of fairly basic problems might go unchecked.As we are using
[ ]
instead of[[ ]]
at least in most places then we should always double quote variables if we don't want empty variables to error out e.g. as in: Dasharo/dasharo-issues#1156 (comment)Left couple
[ $? -eq ...]
as is: