Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.hardkernel_odroid_h4: change EDK2 revision #607

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

m-iwanicki
Copy link

Fixes missing subhook repository and failed git clone

Fixes missing subhook repository and failed git clone

Signed-off-by: Michał Iwanicki <[email protected]>
@m-iwanicki m-iwanicki requested a review from pietrushnic January 3, 2025 23:04
@pietrushnic
Copy link
Contributor

@m-iwanicki, what tests did you do to confirm this change works?

@m-iwanicki
Copy link
Author

Just tested that it builds (it didn't before because of missing subhook repository).
Commit used is identical to one already on dasharo branch:

CONFIG_EDK2_TAG_OR_REV="b7e299856027725ceb5b8da7b52f8a395b665f49"

@pietrushnic
Copy link
Contributor

Yeah, I'm unsure if that is enough to confirm that the exercises will look the same and we will have no regression.

@miczyg1
Copy link
Contributor

miczyg1 commented Jan 7, 2025

Yeah, I'm unsure if that is enough to confirm that the exercises will look the same and we will have no regression.

Well you have to merge it anyway, otherwise it will not build, because a public submodule used by edk2 has gone private...

@mkopec
Copy link
Member

mkopec commented Jan 7, 2025

here's my workaround for the missing subhook submodule that doesn't require touching the code: https://github.com/Dasharo/fwbuild/blob/237d95870ee3a79617165a109a18e3a3f426254f/v540tu/uefi/v0.9.0/bios/FWBUILD#L64-L65

@macpijan
Copy link
Contributor

macpijan commented Jan 8, 2025

Also, there was a branch before set in the config, which is not reproducible. So we do not really know for sure, from which revision these binaries have been built before.

If we need to be sure that there won't be regressions, we can use the very same binaries we have used before - if we still have them somewhere.

Going further, why do we need the hwio branch? It would be best if we could simply use one of the tagged releases (even RC tags) for the training purposes.

I see no other way in moving forward here as merging this PR. In the next step, we can consider whether we need a separate branch, as using a tag or even a specific commit from dasharo branch would help to avoid desync.

@macpijan macpijan merged commit fcc8adb into hwio_2024 Jan 8, 2025
3 checks passed
@macpijan macpijan deleted the hwio_2024_git_fix branch January 8, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants