Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows11 shutdown fix #435

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Nov 14, 2023

No description provided.

@miczyg1 miczyg1 requested a review from mkopec November 14, 2023 14:51
@miczyg1
Copy link
Contributor Author

miczyg1 commented Nov 14, 2023

Fixes: Dasharo/dasharo-issues#562

@macpijan
Copy link
Contributor

I rebased to enable CI build

@mkopec
Copy link
Member

mkopec commented Nov 15, 2023

@miczyg1 could you summarize here what are the effects of switching to SCM on Linux?

@miczyg1 miczyg1 force-pushed the windows11_shutdown_fix branch from 86c336a to 1b92803 Compare November 16, 2023 12:23
The EC PTS and WAK hooks are now called from global _PTS and _WAK
methods if EC hook is available. Drop the redndant calls from
mainboard code.

Signed-off-by: Michał Żygowski <[email protected]>
The code after compilation and decompilation was not identical. Adding
the parentheses fixes the issue. Example:

Code:

If (((MBOX & 0x04) == Zero))

After compilation and decompilation:

If ((MBOX & Zero))

When this fix is applied, the source code is identical to the code after
decompilation.

Signed-off-by: Michał Żygowski <[email protected]>
Fixes the issue with Windows 11 shutdown on certain laptops when S0ix
is enabled. TGL does not support SW CM and FW CM should be kept.

Signed-off-by: Michał Żygowski <[email protected]>
@miczyg1 miczyg1 force-pushed the windows11_shutdown_fix branch from 1b92803 to cfb2732 Compare November 17, 2023 12:02
@miczyg1 miczyg1 merged commit cfb2732 into novacustom_hotfix_release Nov 17, 2023
0 of 4 checks passed
@miczyg1 miczyg1 deleted the windows11_shutdown_fix branch November 17, 2023 12:02
@miczyg1
Copy link
Contributor Author

miczyg1 commented Nov 17, 2023

@miczyg1 could you summarize here what are the effects of switching to SCM on Linux?

Dock is still working on ADL as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants