Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ThrowsExceptions false after initialization #354

Open
wants to merge 1 commit into
base: Development
Choose a base branch
from

Conversation

Aytackydln
Copy link
Contributor

Problem:
When provider is initialized with throwExceptions = true, UpdateQueue throws exceptions in thread-pool and crashes application

Hopefully this is an acceptable solution.

@DarthAffe
Copy link
Owner

This is an intended behavior - throwExceptions primarily meant as a debug-feature. If you want to listen to exceptions without them being thrown you should use the Exception event instead. (You can also selectively throw using this event.)

@Aytackydln
Copy link
Contributor Author

Well using Exception event is the idea, actually. When initialized with throwExceptions Exception event isn't triggered. Maybe this should be a public property intead?

@DarthAffe
Copy link
Owner

When initialized with throwExceptions Exception event isn't triggered.

this would be a bug, but i just checked everything and I don't see any reason why it should be fired. Are you sure that's the case?

@Aytackydln
Copy link
Contributor Author

Oh wait, it does but app crash is the problem but you only mean it to be used for debugging.

Using throwExceptions true makes my code cleaner, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants