Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some decryption issues #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some decryption issues #51

wants to merge 3 commits into from
+22 −5

Conversation

luk-s
Copy link

@luk-s luk-s commented Mar 22, 2020

These changes should solve (at least some of) the decryption issues mentioned in issue #18. See my comment there for a more detailed description. :)

@luk-s luk-s mentioned this pull request Mar 22, 2020
Open
@luk-s luk-s changed the title Fix some decrytion issues Fix some decryption issues Mar 22, 2020
SaltyCybernaut
SaltyCybernaut reviewed Mar 31, 2020
View reviewed changes
Copy link

@SaltyCybernaut SaltyCybernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend squashing this commit into the first commit. Try using an interactive rebase.

@luk-s
Copy link
Author

luk-s commented Apr 11, 2020

I believe it wasn't fixed in my first commit either or was it? Maybe I'm just missing something. Anyways, I created a new commit which should fix these indentation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaltyCybernaut SaltyCybernaut SaltyCybernaut left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luk-s @SaltyCybernaut