Draft: Changes to compile on linux #142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N00byKing
commented
Dec 14, 2023
| @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.0.0 FATAL_ERROR) | |||
| option(ONUT_BUILD_SAMPLES "Build the samples" OFF) | |||
| option(ONUT_BUILD_STANDALONE "Build the Javascript Stand Alone" OFF) | |||
| option(ONUT_BUILD_UI_EDITOR "Build the UI Editor" OFF) | |||
| option(ONUT_USE_SDL "Use SDL+OpenGL on Windows instead of Win32/D3D11/DI8" OFF) | |||
| option(ONUT_USE_SDL "Use SDL+OpenGL on Windows instead of Win32/D3D11/DI8" ON) | |||
There was a problem hiding this comment.
While I would personally recommend focusing on a cross-platform toolkit, this change is just a placeholder for cleaner separation.
| add_subdirectory(./thirdparty/SDL ./thirdparties/SDL) | ||
| list(APPEND libs SDL2-static) | ||
| else() | ||
| list(APPEND libs SDL2) |
There was a problem hiding this comment.
Had compile issues with the SDL2 submodule, but doesnt really matter because most linux systems ship their own shared lib of SDL2 anyway.
| @@ -26,7 +26,7 @@ float Vector2::Angle(const Vector2& from, const Vector2& to) | |||
| { | |||
| if (from == to) return 0.0f; | |||
| auto dir = to - from; | |||
| auto rad = std::atan2f(dir.y, dir.x); | |||
There was a problem hiding this comment.
Probably some issue with C++ version you're giving cmake. For now just use the function from C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this + the DOOM PR, compiling and joining games works.
This one is not very clean because I ran out of time lmao