Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP update deps & code to @grpc/grpc-js #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Quezion
Copy link

@Quezion Quezion commented Jan 21, 2022

  • Tried changing grpc -> @grpc/grpc-js. First commit in PR is using older versions of the library
  • Old grpc will not compile Can't install grpc m1 Mac grpc/grpc-node#1880
  • Current 'npm run build' hits TypeScript error in conversation.ts

I tried bumping @grpc library versions but it doesn't change the error. I'm not familiar with TypeScript & didn't recognize how to resolve this error... but maybe it's obvious to a TS dev?

$ npm run build

> [email protected] build
> rm -rf lib && rollup -c rollup.config.ts


src/assistant.ts → lib/assistant.js, lib/assistant.mjs...
created lib/assistant.js, lib/assistant.mjs in 576ms

src/audio-conversation.ts → lib/audio-conversation.js, lib/audio-conversation.mjs...
created lib/audio-conversation.js, lib/audio-conversation.mjs in 353ms

src/common.ts → lib/common.js, lib/common.mjs...
created lib/common.js, lib/common.mjs in 317ms

src/conversation.ts → lib/conversation.js, lib/conversation.mjs...
[!] (plugin rpt2) Error: /Users/qyarbrough/repos/dabolus/nodejs-assistant/src/conversation.ts(59,24): semantic error TS2769: No overload matches this call.
  Overload 1 of 3, '(chunk: AssistRequest, cb?: Function): void', gave the following error.
    Argument of type '(err: Error) => void' is not assignable to parameter of type 'AssistRequest'.
      Property 'audioIn' is missing in type '(err: Error) => void' but required in type '{ audioIn: Buffer; config?: never; }'.
  Overload 2 of 3, '(chunk: AssistRequest, encoding?: any, cb?: Function): void', gave the following error.
    Argument of type '(err: Error) => void' is not assignable to parameter of type 'AssistRequest'.
      Type '(err: Error) => void' is not assignable to type '{ audioIn: Buffer; config?: never; }'.
src/conversation.ts

This is the codeblock that the compiler is error'ing on (~line 59):

  public end(): Promise<void> {
    return new Promise((resolve, reject) => {
      this._stream.end((err: Error) => {
        if (err) {
          reject(err);
        } else {
          resolve();
        }
      });
    });
  }

Related to #30, may fix or get one step closer to running on Mac M1

I found a similar PR that upgrades to @grpc at stephenh/ts-proto#401 -- but looks like they didn't run into TS errors on upgrade.

Try changing grpc -> @grpc/grpc-js
Old grpc will not compile grpc/grpc-node#1880
Current 'npm run build' hits TypeScript error in conversation.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant