Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji to data_file_checks and log_file_checks printouts to make it #82

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

eflumerf
Copy link
Member

@eflumerf eflumerf commented Oct 3, 2024

more clear which messages indicate success, failure, or skipped checks.

more clear which messages indicate success, failure, or skipped checks.
@eflumerf eflumerf requested a review from bieryAtFnal October 3, 2024 19:16
@eflumerf
Copy link
Member Author

eflumerf commented Oct 3, 2024

Sample output:

---------- DRUNC Run END ----------
.
🚧 Note: problems found in 2 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_local-connection-server.log were ignored based on 2 phrase(s). 🚧
🚧 Note: problems found in 5 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_root-controller.log were ignored based on 4 phrase(s). 🚧
🚧 Note: problems found in 6 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_ru-controller.log were ignored based on 4 phrase(s). 🚧
🚧 Note: problems found in 14 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_ru-01.log were ignored based on 1 phrase(s). 🚧
🚧 Note: problems found in 14 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_ru-02.log were ignored based on 1 phrase(s). 🚧
🚧 Note: problems found in 12 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_df-controller.log were ignored based on 4 phrase(s). 🚧
🚧 Note: problems found in 31 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_tp-stream-writer.log were ignored based on 1 phrase(s). 🚧
🚧 Note: problems found in 1 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_dfo-01.log were ignored based on 1 phrase(s). 🚧
🚧 Note: problems found in 6 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_trg-controller.log were ignored based on 4 phrase(s). 🚧
🚧 Note: problems found in 6 lines in /tmp/pytest-of-eflumerf/pytest-251/run1/log_eflumerf_local-2x3-config_hsi-controller.log were ignored based on 4 phrase(s). 🚧
.
✅ Sanity-check passed
✅ All Attribute tests passed for file test_raw_run000101_0000_df-03_dw_0_20241003T191325.hdf5
✅ Trigger Candidate fragment count of 1 confirmed in all 13 events
✅ All Trigger Candidate fragments in 13 events have sizes between 72 and 216
✅ HSI fragment count of 1 confirmed in all 13 events
✅ All HSI fragments in 13 events have sizes between 72 and 100
✅ WIBEth fragment count of 8 confirmed in all 13 events
✅ All WIBEth fragments in 13 events have sizes between 7272 and 289440
✅ Trigger with TPs fragment count of 6 confirmed in all 13 events
✅ All Trigger with TPs fragments in 13 events have sizes between 72 and 16000

Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and this would have helped me more quickly find the one "check" that was failing in one of the tests that I ran earlier today.

@eflumerf eflumerf merged commit 46d61ce into develop Oct 8, 2024
1 check passed
@eflumerf eflumerf deleted the eflumerf/Emoji branch October 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants