-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectivity service for application/controller control endpoint #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of `hostname`, resolves `grpc` being unable to connect to children processes
plasorak
force-pushed
the
plasorak/app-conn-svc
branch
from
September 17, 2024 14:24
5c90ff2
to
0f3a13f
Compare
…nnectivity service
…broadcast with it
…ity service for now
plasorak
changed the title
Application connectivity service
Connectivity service for application/controller control endpoint
Oct 4, 2024
…mplicated to read in log files
This was referenced Oct 10, 2024
To test:
Then:
Note that with these tests, you will check that:
|
PawelPlesniak
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all, everything boots and confs as expected. Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the connectivity server is used advertise control endpoint for drunc-controller and daq_application.
Here is an example of how the connections are registered in the connectivity service:
So
data_type
s areRunControlMessage
s and the protocol of the URIs denotes the type of endpoint (gRPC or REST-API).This allows dynamic port allocation for both the controllers and the applications, therefore remove the need to offset/change ports etc.
Related PRs:
Configurations don't necessary need to change but in that case they won't have dynamic port allocation for the control endpoint. Following are PRs where I have modified the control services in configuration: