Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TP Time Over Threshold Minima Configurables. #161

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aeoranday
Copy link
Member

@aeoranday aeoranday commented Dec 9, 2024

Incoming signals will have a width (time over threshold) that is greater than incoming noise. I've added a configurable filter that passes TPs with a width that is at least the configured value.

This filter becomes more useful at lower signal amplitude thresholds, but it will require signal shape knowledge to make an accurate estimate on what may be a reasonable amplitude-width threshold combination.

I've made the range of values [1..65535], but the upper limit in this range is essentially infinite. I expect typical values to be in the range [1..20].

Linked PRs

Testing

Completing the usual system tests in daqsystemtest and a local session test run with various tot_minimum_plane<n> values.

  • At a TOT minimum of 1, this should be the same as it has been.
  • At a TOT minimum > 1, the default emulated signals are suppressed since they are a width of 1.
  • At a TOT minimum > 1 and using /cvmfs/dunedaq.opensciencegrid.org/assets/files/b/6/8/wibeth_single_channel.bin, the TP time_over_threshold / 32 ranges from the configured minimum to 63. These values are expected for the pedestal estimation and shape of the emulated signal (rectangle of amplitude = 666 and width = 63).

Completed a low amplitude threshold online test with NP04. Resultant TPs are as expected and the system was able to keep up for reasonable amplitude-width threshold combinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant