Add TP Time Over Threshold Minima Configurables. #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming signals will have a width (time over threshold) that is greater than incoming noise. I've added a configurable filter that passes TPs with a width that is at least the configured value.
This filter becomes more useful at lower signal amplitude thresholds, but it will require signal shape knowledge to make an accurate estimate on what may be a reasonable amplitude-width threshold combination.
I've made the range of values
[1..65535]
, but the upper limit in this range is essentially infinite. I expect typical values to be in the range[1..20]
.Linked PRs
Testing
Completing the usual system tests in
daqsystemtest
and a local session test run with varioustot_minimum_plane<n>
values./cvmfs/dunedaq.opensciencegrid.org/assets/files/b/6/8/wibeth_single_channel.bin
, the TPtime_over_threshold / 32
ranges from the configured minimum to 63. These values are expected for the pedestal estimation and shape of the emulated signal (rectangle of amplitude = 666 and width = 63).Completed a low amplitude threshold online test with NP04. Resultant TPs are as expected and the system was able to keep up for reasonable amplitude-width threshold combinations.