Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing CustomTCMaker, replaced by vector of RandomTCMakers #156

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Removing CustomTCMaker, replaced by vector of RandomTCMakers #156

merged 1 commit into from
Nov 18, 2024

Conversation

ArturSztuc
Copy link
Contributor

PR explained in DUNE-DAQ/trigger#364

@ArturSztuc ArturSztuc mentioned this pull request Nov 14, 2024
Merged
aeoranday
aeoranday approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@aeoranday aeoranday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested online and by emulation.

@ArturSztuc ArturSztuc merged commit 101bfdf into develop Nov 18, 2024
2 checks passed
@ArturSztuc ArturSztuc deleted the asztuc/removing_customtcmaker branch November 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeoranday aeoranday aeoranday approved these changes

@MRiganSUSX MRiganSUSX Awaiting requested review from MRiganSUSX

@schhibra schhibra Awaiting requested review from schhibra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturSztuc @aeoranday