Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set the empty string as we display it on the scoreboard #2538

Merged
merged 1 commit into from
May 31, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented May 10, 2024

We state we fallback but would pick the empty string now,

@meisterT
Copy link
Member

I seem to remember that we also had an issue with nulls but cannot find it quickly in the code.

@vmcj
Copy link
Member Author

vmcj commented May 10, 2024

I seem to remember that we also had an issue with nulls but cannot find it quickly in the code.

I do remember the same, but PHPStan seems to be happy so it should be allowed. I think I do prefer null for this specific case or to make the choice explicit here, so if display_name is not set start to guess on something else, the earlier code did not do that so I didn't add it but this feels a bit like having too many fields for the same thing.

We state we fallback but would pick the empty string now,
@vmcj vmcj force-pushed the display_not_set_emptystring branch from 8223341 to c9baf43 Compare May 11, 2024 13:40
@vmcj vmcj added this pull request to the merge queue May 31, 2024
Merged via the queue into DOMjudge:main with commit 9974cec May 31, 2024
22 checks passed
@vmcj vmcj deleted the display_not_set_emptystring branch May 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants