Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Resource Tagging, NIST and newer versions of CIS #15

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

timrologicly
Copy link
Contributor

There are a few new standards in AWS Security Hub that aren't covered by this module, including:

This PR aims to address those limitations.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

These modifications could be considered to be breaking changes, as the default version of CIS AWS Foundations Benchmark has been set to v3.0.0, whereas previously it was hard-coded to v1.2.0. If this is undesirable behaviour, the default value can be dropped back to "1.2.0".

Copy link
Member

@Renatovnctavares Renatovnctavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @timrologicly

@Renatovnctavares Renatovnctavares merged commit 6cc6fad into DNXLabs:master Jul 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants