better naming for convert operation (#39)

DAXGRID · Jan 3, 2022 · de2c5c1 · de2c5c1
1 parent 369b10f
commit de2c5c1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/MsSqlCdc/DataConvert.cs b/src/MsSqlCdc/DataConvert.cs
@@ -33,7 +33,7 @@ bool isDefaultCdcField(string fieldName) =>
             (byte[])columnFields.First(x => x.fieldName == CdcFieldName.StartLsn).fieldValue);
         var seqVal = ConvertBinaryLsn(
             (byte[])columnFields.First(x => x.fieldName == CdcFieldName.SeqVal).fieldValue);
-        var operation = ConvertIntOperation(
+        var operation = ConvertOperation(
             (int)columnFields.First(x => x.fieldName == CdcFieldName.Operation).fieldValue);
         var updateMask = Encoding.UTF8.GetString(
             (byte[])columnFields.First(x => x.fieldName == CdcFieldName.UpdateMask).fieldValue);
@@ -69,7 +69,7 @@ public static long ConvertBinaryLsn(byte[] bytes) => BitConverter.IsLittleEndian
     /// <param name="representation">The number representation of the Operation.</param>
     /// <returns>Enum representation of the number representation.</returns>
     /// <exception cref="ArgumentException"></exception>
-    public static Operation ConvertIntOperation(int representation)
+    public static Operation ConvertOperation(int representation)
         => representation switch
         {
             1 => Operation.Delete,

diff --git a/test/MsSqlCdc.Tests/DataConvertTest.cs b/test/MsSqlCdc.Tests/DataConvertTest.cs
@@ -290,7 +290,7 @@ public void Conversion_cdc_column_without_default_fields_is_invalid(
     [InlineData(4, Operation.AfterUpdate)]
     public void Operation_valid_number_representation_should_be_converted(int input, Operation expected)
     {
-        var operation = DataConvert.ConvertIntOperation(input);
+        var operation = DataConvert.ConvertOperation(input);
         operation.Should().Be(expected);
     }
 
@@ -303,7 +303,7 @@ public void Operation_valid_number_representation_should_be_converted(int input,
     [InlineData(int.MaxValue)]
     public void Operation_invalid_number_representation_should_not_be_converted(int input)
     {
-        Invoking(() => DataConvert.ConvertIntOperation(input)).Should().Throw<ArgumentException>();
+        Invoking(() => DataConvert.ConvertOperation(input)).Should().Throw<ArgumentException>();
     }
 
     [Theory]