Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CycloneDxAggregateEnforceMojo #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XenoAmess
Copy link

@XenoAmess XenoAmess commented May 7, 2022

close #182
also, close #177

pom.xml Outdated Show resolved Hide resolved
@XenoAmess XenoAmess force-pushed the add_enforce_mojo_functionality branch 2 times, most recently from 9c14eb8 to a3814e7 Compare May 8, 2022 00:03
pom.xml Outdated Show resolved Hide resolved
@stevespringett
Copy link
Member

Thanks for the PR. Note: Code originating from the SPDX project is prohibited due to a history of publicly documented plagiarism from that project. Allow and deny lists are simple enough to implement. Please consider another way to implement without the use of SPDX libraries or code snippets.

@XenoAmess
Copy link
Author

XenoAmess commented May 8, 2022

Thanks for the PR. Note: Code originating from the SPDX project is prohibited due to a history of publicly documented plagiarism from that project. Allow and deny lists are simple enough to implement. Please consider another way to implement without the use of SPDX libraries or code snippets.

@stevespringett
I don't think parsing SPDX lincense expression is a very easy thing.
Is there any guide on it?
Do you mean I shall re-write it using something like antlr4?

@XenoAmess XenoAmess force-pushed the add_enforce_mojo_functionality branch from eef20db to 91feaf3 Compare May 8, 2022 00:32
@stevespringett
Copy link
Member

https://pypi.org/project/license-expression/ is a good example of a clean-room implementation. It's written in Python. All the Java implementations I've seen are simple wrappers around the Java SPDX tools which we should be avoiding.

@XenoAmess XenoAmess force-pushed the add_enforce_mojo_functionality branch from 91feaf3 to 9647fa1 Compare March 9, 2023 22:19
@XenoAmess XenoAmess force-pushed the add_enforce_mojo_functionality branch from 9647fa1 to 1a43f98 Compare March 9, 2023 22:45
@XenoAmess
Copy link
Author

@stevespringett spdx license part removed. please have a review. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants