Cache object stores per scheme + bucket #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
commented
Jan 16, 2025
| @@ -4,5 +4,6 @@ trap "echo 'Caught termination signal. Exiting...'; exit 0" SIGINT SIGTERM | |||
|
|
|||
| # create azurite container | |||
| az storage container create -n $AZURE_TEST_CONTAINER_NAME --connection-string $AZURE_STORAGE_CONNECTION_STRING | |||
| az storage container create -n ${AZURE_TEST_CONTAINER_NAME}2 --connection-string $AZURE_STORAGE_CONNECTION_STRING | |||
There was a problem hiding this comment.
created one more container to test object store cache per (schema, container) pair.
aykut-bozkurt
force-pushed
the
aykut/cache-object-stores
branch
from
39bbefe to
17d4aa8
Compare
marcoslot
reviewed
Jan 21, 2025
| let expiration_warn_msg = | ||
| format!("credentials for {bucket} expired at {expire_at:?}"); | ||
|
|
||
| let expiration_hint = "New credentials will be automatically retrieved if configured.\n\ |
There was a problem hiding this comment.
if new credentials will be automatically retrieved, do we need to throw a warning?
There was a problem hiding this comment.
wanted to give hint to refresh the session but seems like a bad spot. (retry should not warn if it succeeds)
marcoslot
reviewed
Jan 21, 2025
|
|
||
| if let Some(item) = self.cache.get(&key) { | ||
| if item.expired(&key.bucket) { | ||
| self.cache.remove(&key); |
There was a problem hiding this comment.
does this release all the memory associated with the object store?
There was a problem hiding this comment.
yep, impl Drop is called for each field in the structs.
aykut-bozkurt
force-pushed
the
aykut/numeric-with-larger-scale
branch
from
b8f9061 to
80f9a11
Compare
In this PR, we cache object stores per scheme (e.g. s3) + bucket (container) combination in each Postgres session. This will reduce authentication costs by only doing it at the first time. object_store does not perform sts assume_role to get temp token, so pg_parquet make use of aws sdk to perform it. And then configure object_store with the temp token that it fetched. This is why, pg_parquet checks expiration of the tokens for s3 store. It will fetch the temp token if it expires. (obviously if you configured temp token auth via config) For azure blob store, we do not need to recreate tokens because object_store handles it.
aykut-bozkurt
force-pushed
the
aykut/cache-object-stores
branch
from
17d4aa8 to
9d90243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we cache object stores per scheme (e.g. s3) + bucket (or container) combination in each Postgres session. This will reduce authentication costs by only doing it at the first time.
object_store does not perform sts assume_role to get temp token, so pg_parquet make use of aws sdk to perform it. And then configure object_store with the temp token that it fetched. This is why, pg_parquet checks expiration of the tokens for s3 store. It will fetch the temp token if it expires. (obviously if you configured temp token auth via config)
For azure blob store, we do not need to recreate tokens because object_store handles it.
Closes #93