Support copying numerics with larger scale than precision #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/error-if-special-numeric
branch
from
fa13238 to
58327af
Compare
aykut-bozkurt
force-pushed
the
aykut/numeric-with-larger-scale
branch
from
d05fcf3 to
0cc2487
Compare
aykut-bozkurt
force-pushed
the
aykut/error-if-special-numeric
branch
from
58327af to
4637490
Compare
aykut-bozkurt
force-pushed
the
aykut/numeric-with-larger-scale
branch
from
0cc2487 to
b8f9061
Compare
marcoslot
approved these changes
Jan 19, 2025
| scale = 0; | ||
| } | ||
|
|
||
| // Even if PG allows scale to be greater than precision, arrow does not. We set precision to scale. |
There was a problem hiding this comment.
could be good to comment on why this is ok
aykut-bozkurt
force-pushed
the
aykut/error-if-special-numeric
branch
from
4637490 to
4056ad2
Compare
aykut-bozkurt
force-pushed
the
aykut/numeric-with-larger-scale
branch
from
b8f9061 to
80f9a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parquet, we cannot write numeric with larger scale than precision. But postgres allows it. We can adjust the numeric typmod in that case.