Laravel 5.8, Testing and more Features #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated composer.json to support laravel 5.7
Fixed tests for Laravel 5.7
minor modifications
Fixed migration being published multiple times Added more tests Fixed setGlobalTax and setGlobalDiscount
Added Readme for merge
Add changes from Crinsane#349 Add changes from Crinsane#478
Added codecov
Added coverage.xml to .gitignore
Added secondary build for low dependency versions Adjusted dependencies to supported php versions
Added more tests
Cleaned up __get methods
Removed EOL php versions Added weight option from Crinsane#502 Improved Code quality and testing
…versions.md#version-range Added 5.8.* compatibility Updated dependency versions Added phpunit result cache to gitignore
Laravel 5.8
The CartItem::fromAttributes call is missing the $weight parameter, and the CartItemOptions don't work any more because of this.
Update Cart.php, fix CartItem::fromAttributes call
Remove strlen from weight
Revert last change
Changed default value of $weight to 0
Added Test for CartItem.php invalid weight exception.
Codestyle
#11 Fixed copypasta in the Readme
#8 Added missing publish group parameter
Reverted package name to the original
Open
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage ? 100%
Complexity ? 136
=======================================
Files ? 5
Lines ? 356
Branches ? 0
=======================================
Hits ? 356
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
This is a must PR @Crinsane ! |
|
is this going to merge soon? can't install even on dev-master. |
|
some of this is already has PR in here #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this was requested, i want to merge back my version of the Package containing a lot of open Pull Requests from here and some other additions i have made. The summary of additions can be obtained from the commit history and/or the appropiate PR or Issue on this repository directly but i am going to provide a complete list if needed. I just want to apologize in advance for the many fail commits.
Features:
Included PR's: