Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basePath edge-case in registerSound #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

porglezomp
Copy link

When calling registerSound with an object for src, like for instance when handling a data URL with { src: { mp3: ... }, type: "sound" }, the id would get set as a basePath, and some inconsistent treatment of falsy values would lead to the id getting prepended to the URL. This fixes things so that sounds can be registered with data URLs.

Fixes #120

When calling registerSound with an object for src, like for instance
when handling a data URL with { src: { mp3: ... }, type: "sound" }, the
id would get set as a basePath, and some inconsistent treatment of falsy
values would lead to the id getting prepended to the URL. This fixes
things so that sounds can be registered with data URLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoundJS does not support data URIs
2 participants