[WIP] - Refactor SoundJS lib with good practices #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for the contribution! We'll review this when we get a chance to see if there's good value in these changes. Unfortunately, we might not get to it right away - vetting these changes might be a fairly large task given the amount of them, and things like needing to make sure this works with our autodocs etc. Right now our priority on the CreateJS libraries is working on the 2.0 versions, which in the case of SoundJS 2.0, is a complete rewrite. |
|
Thanks for review! Your feedback was very important! |
|
Genius reply. Thank you so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have a college evaluation to help with good coding practices a repository.
I hope my changes helps xD
Best practices or guidelines related to: