Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT:] Styled headings and form #58

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DRAFT:] Styled headings and form #58

wants to merge 2 commits into from

Conversation

YuriDevAT
Copy link
Contributor

@YuriDevAT YuriDevAT commented Dec 26, 2023

Description

I started applying the styling we decided in Figma.

Current state

  • Logo
  • Heading 1
  • Heading 2
  • Form (label, input, button)
  • Progressbar
  • List

Link to Figma File: https://www.figma.com/file/FnY3XGLmYCSpMKoEDEqcPF/HTML-Tag-Quiz?type=design&node-id=0%3A1&mode=design&t=yayElEf78YayM21g-1

Related Issue

Closes #35

Acceptance Criteria

Type of Changes

Type
πŸ› Bug fix
✨ New feature
x πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Updates

Before

Original state of the app

After

Current state of the app

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Testing Steps / QA Criteria

  • I am not satisfied with the names I came up with for the CSS variables
  • I got rid of the class names and using tags instead. Reason for this is, that the app is small, and I wanted to take the chance to learn more about parent / child / element relations and using +, > and such, as well as [type=""]

@YuriDevAT YuriDevAT added the CSS Work on CSS stylesheet label Dec 26, 2023
Copy link

netlify bot commented Dec 26, 2023

βœ… Deploy Preview for html-tag-quiz ready!

Name Link
πŸ”¨ Latest commit 06c4ef7
πŸ” Latest deploy log https://app.netlify.com/sites/html-tag-quiz/deploys/6592e39ab124b200087c4ae0
😎 Deploy Preview https://deploy-preview-58--html-tag-quiz.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CorinaMurg
Copy link
Owner

This looks great! I was able to make sense of the css variables (but I understand the pain of coming up with good names!)

I'm also excited about the change from classes to tags! It just so happens that I am using the same approach on a project right now (it's a bigger code base, so I am still using quite a lot of classes) but instead of a class for everything (like I used to) I'm relying more on parent-child relationships and nth-of-child / :not() etc. As someone whose never been a big fan of CSS, I am starting to understand it and like it more this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Work on CSS stylesheet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Color of the app
2 participants