Propose sim amplitude/offset fix

[garrettwrong]

There is more to do/check here, but I think this resolves the behavior reported in #1196 and preserves the ability to set these properties upstream.

@j-c-c , can you continue working this issue (validating and creating some tests). Also we should check for other properties that might have been missed by the same oversight in the past. (I'm thinking rotations? 😬 )

Thanks

[garrettwrong]

Cancelled workflow. The tests that fail are the following:

FAILED tests/test_simulation.py::SimTestCase::testSimulationCached - AssertionError: 
FAILED tests/test_simulation.py::SimTestCase::testSimulationImages - AssertionError: 
FAILED tests/test_simulation.py::SimTestCase::testSimulationImagesDownsample - AssertionError: 
FAILED tests/test_simulation.py::SimTestCase::testSimulationImagesNoisy - AssertionError: 
FAILED tests/test_anisotropic_noise.py::SimTestCase::testAnisotropicNoisePSD - AssertionError: False is not true
FAILED tests/test_anisotropic_noise.py::SimTestCase::testAnisotropicNoiseVariance - AssertionError: False is not true

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (d221210) to head (8192ac7).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1200   +/-   ##
========================================
  Coverage    87.37%   87.37%           
========================================
  Files          132      132           
  Lines        13637    13639    +2     
========================================
+ Hits         11915    11917    +2     
  Misses        1722     1722           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[j-c-c]

@garrettwrong I don't think I can officially tag you to review this since you are an author, but this is ready if you want to take a look at the changes I added.

[garrettwrong]

As co-author, can't approve but looks good, thanks!

[janden]

LGTM!