Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter Overwrite #1191

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Smarter Overwrite #1191

merged 16 commits into from
Oct 28, 2024

Conversation

j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Oct 8, 2024

Set default overwrite to rename existing files with timestamp for Image, Volume, and ImageSource.

@j-c-c j-c-c added the cleanup label Oct 8, 2024
@j-c-c j-c-c self-assigned this Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (51bcda7) to head (ee7c5a1).
Report is 16 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1191      +/-   ##
===========================================
+ Coverage    90.06%   90.09%   +0.02%     
===========================================
  Files          132      132              
  Lines        13735    13769      +34     
===========================================
+ Hits         12371    12405      +34     
  Misses        1364     1364

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-c-c j-c-c linked an issue Oct 9, 2024 that may be closed by this pull request
Smarter overwrite flag #892
Closed
@j-c-c
Copy link
Collaborator Author

j-c-c commented Oct 9, 2024

@garrettwrong I added a file renaming method as discussed (with a test). Should be good for you to look at now. Thanks.

garrettwrong
garrettwrong previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, nice test coverage. Thanks for putting together. I think the tests can be tweaked a little to be more direct then should be good to go. Thanks!

src/aspire/utils/__init__.py Outdated Show resolved Hide resolved
src/aspire/utils/misc.py Show resolved Hide resolved
tests/test_image.py Outdated Show resolved Hide resolved
tests/test_simulation.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
garrettwrong
garrettwrong previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@j-c-c j-c-c marked this pull request as ready for review October 18, 2024 18:26
@j-c-c j-c-c requested a review from janden as a code owner October 18, 2024 18:26
@garrettwrong
Copy link
Collaborator

Try picking something after epoch (1970) 😇

@j-c-c j-c-c marked this pull request as draft October 21, 2024 19:32
@j-c-c
Copy link
Collaborator Author

j-c-c commented Oct 21, 2024

@janden @garrettwrong converting this back to a draft. Just noticed I missed MicrographSource.save.

@j-c-c
Copy link
Collaborator Author

j-c-c commented Oct 23, 2024

@garrettwrong I added the new overwrite behavior to MicrographSimulation and a supporting test. I'll let you take a peek before I mark ready for review. Thanks!

garrettwrong
garrettwrong previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@j-c-c j-c-c marked this pull request as ready for review October 23, 2024 17:39
garrettwrong
garrettwrong previously approved these changes Oct 23, 2024
View reviewed changes
janden
janden requested changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a few comments here.

src/aspire/utils/misc.py Outdated Show resolved Hide resolved
src/aspire/source/image.py Outdated Show resolved Hide resolved
src/aspire/utils/misc.py Outdated Show resolved Hide resolved
@j-c-c j-c-c merged commit 66d2e7a into develop Oct 28, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janden janden janden approved these changes

@garrettwrong garrettwrong garrettwrong left review comments

Assignees

@j-c-c j-c-c

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smarter overwrite flag
3 participants
@j-c-c @garrettwrong @janden