Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the additional packages into Dockerfile #12513

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Move the additional packages into Dockerfile

Rationale:

  • Align with other distro

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 18, 2024
Copy link

openshift-ci bot commented Oct 18, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys added this to the 0.1.75 milestone Oct 18, 2024
@jan-cerny jan-cerny assigned dodys and unassigned dodys Oct 18, 2024
@dodys dodys self-assigned this Oct 18, 2024
@dodys dodys added the Ubuntu Ubuntu product related. label Oct 18, 2024
Copy link

codeclimate bot commented Oct 21, 2024

Code Climate has analyzed commit e49e7e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 4d75727 into ComplianceAsCode:master Oct 22, 2024
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants