Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-4655: add support for DISA-STIG on Power #12485

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Oct 10, 2024

Description:

Enables the DISA-STIG on Power

Rationale:

  • Adding DISA STIG to the content image.

MULTIARCH-4655 is an OCP4 ticket.

Review Hints:

Adds ppc64le build

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 10, 2024
Copy link

openshift-ci bot commented Oct 10, 2024

Hi @prb112. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prb112
Copy link
Contributor Author

prb112 commented Oct 10, 2024

/wip

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@prb112
Copy link
Contributor Author

prb112 commented Oct 16, 2024

/retest-required

Copy link

openshift-ci bot commented Oct 16, 2024

@prb112: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prb112
Copy link
Contributor Author

prb112 commented Oct 16, 2024

Hey @yuumasato @rhmdnd @Vincent056 could you mark this as ok-to-test? we're looking to test the disa-stig-v1 on Power.

@jan-cerny
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Oct 17, 2024
@prb112
Copy link
Contributor Author

prb112 commented Oct 17, 2024

/retest

@prb112 prb112 force-pushed the MULTIARCH-4655 branch 2 times, most recently from 9ad50a7 to a4387c0 Compare October 18, 2024 01:07
Copy link

codeclimate bot commented Oct 18, 2024

Code Climate has analyzed commit cd0434d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.0% change).

View more on Code Climate.

@prb112
Copy link
Contributor Author

prb112 commented Oct 18, 2024

/retest

@yuumasato yuumasato self-assigned this Oct 18, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato yuumasato added this to the 0.1.75 milestone Oct 18, 2024
@yuumasato yuumasato added OpenShift OpenShift product related. STIG STIG Benchmark related. labels Oct 18, 2024
@yuumasato yuumasato merged commit 7c1b2ad into ComplianceAsCode:master Oct 18, 2024
102 of 104 checks passed
@prb112
Copy link
Contributor Author

prb112 commented Oct 18, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants