Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33194: Fix text in rule file_groupowner_ovs_conf_db_lock #11939

Conversation

yuumasato
Copy link
Member

@yuumasato yuumasato commented May 3, 2024

Description:

  • The correct path for the db lock file is:
    /etc/openvswitch/.conf.db.~lock~
  • Note: the rule checked the correct path. Only the description was incorrect.

Rationale:

  • The rule description should be accurate.

The correct path for the db lock file is:
/etc/openvswitch/.conf.db.~lock~
Copy link

github-actions bot commented May 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented May 3, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11939
This image was built from commit: ecd5059

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11939

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11939 make deploy-local

Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit ecd5059 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the OpenShift OpenShift product related. label May 8, 2024
@xiaojiey
Copy link
Collaborator

/hold for test

@openshift-ci openshift-ci bot added the do-not-merge/hold Used by openshift-ci-robot bot. label May 20, 2024
@xiaojiey
Copy link
Collaborator

/lgtm
Pre-merge verification pass. Details seen from comment for the bug.

@xiaojiey
Copy link
Collaborator

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Used by openshift-ci-robot bot. label May 30, 2024
Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato yuumasato added this to the 0.1.74 milestone Jun 19, 2024
@yuumasato
Copy link
Member Author

Merging based on reviews...

@yuumasato yuumasato merged commit 42782e6 into ComplianceAsCode:master Jun 19, 2024
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants