Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial OSPP Control File #11882

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Apr 24, 2024

Description:

Create Initial OSPP control file.

This is an automatically created using the script in this branches history.

Rationale:

Get the RHEL 10 draft OSPP profile ready.

@Mab879 Mab879 added New Profile Issues or pull requests related to new Profiles. OSPP OSPP benchmark related. labels Apr 24, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone Apr 24, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 24, 2024
Copy link

openshift-ci bot commented Apr 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 24, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11882
This image was built from commit: 2ae468d

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11882

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11882 make deploy-local

@Mab879 Mab879 marked this pull request as ready for review April 26, 2024 13:12
@Mab879 Mab879 requested a review from a team as a code owner April 26, 2024 13:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 26, 2024
@Mab879 Mab879 requested a review from ggbecker April 26, 2024 13:20
@marcusburghardt
Copy link
Member

@ggbecker , could you take a look, please?

@Mab879
Copy link
Member Author

Mab879 commented Apr 29, 2024

@ggbecker If you suggestions for titles please let me know.

@Mab879
Copy link
Member Author

Mab879 commented Apr 29, 2024

Script for creating this has been posted in #11916

@ggbecker ggbecker self-assigned this Apr 30, 2024
@ggbecker
Copy link
Member

@ggbecker If you suggestions for titles please let me know.

A few things I noticed here.

First, some references changed from OSPP 4.2.1 to 4.3, for example: https://www.niap-ccevs.org/MMO/PP/-442-/#FCS_COP.1(1) is now https://www.niap-ccevs.org/MMO/PP/OS%204.3%20PP/#FCS_COP.1/ENCRYPT, so there is a small change in how it's represented: FCS_COP.1(1) -> FCS_COP.1/ENCRYPT.

Second, you can use the title as defined in this for example: https://www.niap-ccevs.org/MMO/PP/OS%204.3%20PP/#FCS_COP.1/ENCRYPT -> Cryptographic Operation - Encryption/Decryption (Refined)

and last, this table contains the rationale for each requirement that could be used in the description of each control defined: https://www.niap-ccevs.org/MMO/PP/OS%204.3%20PP/#obj-req-map

@vojtapolasek vojtapolasek modified the milestones: 0.1.73, 0.1.74 Apr 30, 2024
Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit 2ae468d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggbecker ggbecker merged commit 4656530 into ComplianceAsCode:master May 29, 2024
113 checks passed
@Mab879 Mab879 deleted the init_rhel10_ospp branch May 29, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Profile Issues or pull requests related to new Profiles. OSPP OSPP benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants