Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible_playbook_to_role util for RHEL 9 #11654

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmc5179
Copy link
Contributor

@dmc5179 dmc5179 commented Mar 6, 2024

Description:

Update ansible_playbook_to_role util for RHEL 9
Switch default branch from master to main
Remove unsupported characters in role names during conversion process; i.e [ and ]

Rationale:

Util needs to be updated to support converting the ansible playbooks from this repo into ansible roles as has been done for RHEL 7 and RHEL 8.

Review Hints:

After building this main content repo, the following command is used to convert the playbooks into roles, which needs the added RHEL 9 support

./utils/ansible_playbook_to_role.py --product rhel9 --profile $p --organization RedHatOfficial --tag-release --token ${GIT_TOKEN} --build-playbooks-dir ./build/ansible/

I have used the updated version of the script for the last few content releases but did not have a chance until now to submit a PR.

… branch, remove unsupported characters from role names
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Mar 6, 2024
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 6, 2024
Copy link

openshift-ci bot commented Mar 6, 2024

Hi @dmc5179. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Mar 6, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Mar 6, 2024
@Mab879
Copy link
Member

Mab879 commented Mar 6, 2024

Please resolve the merge conflicts by rebasing on the latest master.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11654
This image was built from commit: 0e3e3de

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11654

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11654 make deploy-local

Copy link

codeclimate bot commented Mar 27, 2024

Code Climate has analyzed commit f8034e9 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the the PEP8 issues and remove the merge commit from this branch.

utils/ansible_playbook_to_role.py Outdated Show resolved Hide resolved
utils/ansible_playbook_to_role.py Show resolved Hide resolved
@marcusburghardt marcusburghardt added the Ansible Ansible remediation update. label Apr 18, 2024
@dmc5179
Copy link
Contributor Author

dmc5179 commented Apr 19, 2024

@Mab879 I'm not sure how to do that last part, remove the merge commit from this branch.

@Mab879
Copy link
Member

Mab879 commented Apr 26, 2024

@Mab879 I'm not sure how to do that last part, remove the merge commit from this branch.

First all, thanks for the work.

Reviewing the changes I wondering if we can just close this PR.

The [DRAFT] to DRAFT change should no longer be needed as we now use "DRAFT - " as the prefix.

So that only leaves that print statement.

If you want that print statement, with all the recent changes it might be best just to open a new PR based on the latest master.

Again, thanks for the your work and happy to help out if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants