-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ansible_playbook_to_role util for RHEL 9 #11654
base: master
Are you sure you want to change the base?
Conversation
… branch, remove unsupported characters from role names
Hi @dmc5179. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please resolve the merge conflicts by rebasing on the latest master. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit f8034e9 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the the PEP8 issues and remove the merge commit from this branch.
Co-authored-by: Matthew Burket <[email protected]>
Co-authored-by: Matthew Burket <[email protected]>
@Mab879 I'm not sure how to do that last part, remove the merge commit from this branch. |
First all, thanks for the work. Reviewing the changes I wondering if we can just close this PR. The [DRAFT] to DRAFT change should no longer be needed as we now use "DRAFT - " as the prefix. So that only leaves that print statement. If you want that print statement, with all the recent changes it might be best just to open a new PR based on the latest master. Again, thanks for the your work and happy to help out if you need it. |
Description:
Update ansible_playbook_to_role util for RHEL 9
Switch default branch from master to main
Remove unsupported characters in role names during conversion process; i.e [ and ]
Rationale:
Util needs to be updated to support converting the ansible playbooks from this repo into ansible roles as has been done for RHEL 7 and RHEL 8.
Review Hints:
After building this main content repo, the following command is used to convert the playbooks into roles, which needs the added RHEL 9 support
I have used the updated version of the script for the last few content releases but did not have a chance until now to submit a PR.