Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a serial test that shows the behavior of scansetting protection #317

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented May 9, 2023

In splunking through the code, I didn't see any specific code that
protects the default scan settings (default, default-auto-apply)
shipped with the operator.

This commit adds a test to exercise what happens when a user deletes
default scan setting.

@openshift-ci openshift-ci bot requested review from jhrozek and mrogers950 May 9, 2023 16:34
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 9, 2023
In splunking through the code, I didn't see any specific code that
protects the default scan settings (`default`, `default-auto-apply`)
shipped with the operator.

This commit adds a test to exercise what happens when a user deletes
default scan setting.
@rhmdnd rhmdnd force-pushed the add-test-for-scansetting-protection branch from 00b5a34 to c1c0a3d Compare February 2, 2024 18:13
Copy link

openshift-ci bot commented May 10, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial c1c0a3d link true /test e2e-aws-serial
ci/prow/e2e-rosa c1c0a3d link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Author

rhmdnd commented May 29, 2024

Closing this since it's stale.

@rhmdnd rhmdnd closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant