Fix windows multi window crash on Full Screen #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap content in ScrollView in MediaElementCarouselViewPage.xaml - Replace Border with Grid in MediaElementCollectionViewPage.xaml - Use Grid for complex layout in MediaElementMultipleWindowsPage.cs - Add method for foreground window handle in MauiMediaElement.windows.cs - Refactor AppWindow retrieval and fullscreen handling logic - Add methods for screen size retrieval and popup configuration
Modified `CommunityToolkit.Maui.MediaElement.csproj` to allow unsafe code blocks by adding `<AllowUnsafeBlocks>true</AllowUnsafeBlocks>`. Changed `MauiMediaElement` class in `MauiMediaElement.windows.cs` to a partial class. Replaced `DllImport` with `LibraryImport` for `GetForegroundWindow` and marked the method as `internal static partial`.
ne0rrmatrix
changed the title
brminnick
reviewed
Oct 14, 2024
...les/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementMultipleWindowsPage.cs
Outdated
Show resolved
Hide resolved
...les/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementMultipleWindowsPage.cs
Outdated
Show resolved
Hide resolved
…x/MauiOld into FixWindowsMultiWindow
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementCarouselViewPage.xaml: Language not supported
- samples/CommunityToolkit.Maui.Sample/Pages/Views/MediaElement/MediaElementCollectionViewPage.xaml: Language not supported
- src/CommunityToolkit.Maui.MediaElement/CommunityToolkit.Maui.MediaElement.csproj: Language not supported
Update PageExtensions to grab last index window Refactor `MauiMediaElement`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Improve layout and fullscreen handling for MediaElement
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This does not fix all issues with multi window environments in Windows. There is another issue where snackbar option is enabled crashes the app. I will be creating a bug report for that seperately.