-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize TextAlignmentExtensionsGenerator
#321
Draft
brminnick
wants to merge
26
commits into
main
Choose a base branch
from
Update-Analyzers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminnick
changed the title
[Housekeeping] Optimize
[Housekeeping] Optimize Oct 4, 2024
TextAlignmentExtensionsGenerator
and Add CommunityToolkit.Maui.Markup.SourceGenerators.UnitTests
TextAlignmentExtensionsGenerator
brminnick
changed the title
[Housekeeping] Optimize
Optimize Oct 6, 2024
TextAlignmentExtensionsGenerator
TextAlignmentExtensionsGenerator
Here's the current benchmark results. It looks like I still have some work to do to optimize the SourceGenerator to reduce memory allocations Current / Previous TextAlignmentExtensionsGenerator
Updated TextAlignmentExtensionsGenerator
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR improves the performance of
TextAlignmentExtensionsGenerator
, optimizing for memory allocations and processing time.This PR also adds Unit Tests + Benchmarks for
CommunityToolkit.Maui.Markup.SourceGenerators
to ensure no regressions between the previous implementation ofTextAlignmentExtensionsGenerator
and this updated/optimized implementation.PR Checklist
main
at time of PRAdditional information