Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Uno support (updated) #38

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

nickrandolph
Copy link
Collaborator

No description provided.

@nickrandolph nickrandolph marked this pull request as draft January 29, 2021 23:10
@michael-hawker
Copy link
Member

Hey @nickrandolph, sorry for the delay. I didn't see the GitHub notification, not sure if it was because it was a new PR vs. updating the old one.

It seems you hadn't git mv everything. The Xamarin Forms PR has in #33. Could you rebase off that one, then we can also update to compare against it?

Also, I noticed you pinned the SDK Extras to an older version, is there a specific reason you weren't using latest?

And with the Icon Glyphs removed nothing shows for even the UWP sample, right? Does the Uno NavigationViewItem not support the Icons?

Also adding @kazo0 if he has any suggestions as a member of the Uno team and to help us coordinate these two PRs better. Thanks!

@Sergio0694
Copy link
Member

Hey @nickrandolph - if you have time to get back to this please rebase the PR off of main, and ensure that you have no files being deleted/created, but only moved, if any. If you rebase in theory that should at least in part get fixed already, since all the backend viewmodels will have been moved to a separate project already 🙂

@michael-hawker
Copy link
Member

@nickrandolph was this still something you were interested in contributing this? I know a lot has changed between the prior split in this repo to have the separate .NET Standard project to facilitate code-share and then Uno itself with the TreeView in NavigationView support.

Wondering if it makes sense to revive this PR or start a new-one from the latest main branch.

@nickrandolph
Copy link
Collaborator Author

I'm guessing it probably makes sense to take a new branch of current main and add the Uno sample. I'll see whether I have capacity in the coming week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants