Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/379 support active mq artemis #386

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anoordover
Copy link
Contributor

@anoordover anoordover commented Jan 13, 2025

**Closes #379 **

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@aaronpowell aaronpowell requested a review from Copilot January 15, 2025 00:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • examples/activemq/CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit/CommunityToolkit.Aspire.Hosting.ActiveMQ.MassTransit.http: Language not supported
  • src/CommunityToolkit.Aspire.Hosting.ActiveMQ/PublicAPI.Shipped.txt: Language not supported
  • src/CommunityToolkit.Aspire.Hosting.ActiveMQ/ActiveMQContainerImageTags.cs: Evaluated as low risk
  • src/CommunityToolkit.Aspire.Hosting.ActiveMQ/ActiveMQServerResource.cs: Evaluated as low risk
  • src/CommunityToolkit.Aspire.Hosting.ActiveMQ/ActiveMQBuilderExtensions.cs: Evaluated as low risk
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My primary question with the design is whether we want to make it more obvious from the types what kind of ActiveMQ resource you're working with.

So rather than having a single ActiveMQServerResource, we would have ActiveMQServerResource (aka - Classic) and ActiveMQArtemisServerResource which either inherits from ActiveMQServerResource or is its own ContainreResource implementation.

Then we would have methods like AddActiveMQ that exists today and a new AddActiveMQArtemis method that creates an Artemis implementation, which means that it's very clear from the code what server implementation is in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveMQ Artemis support?
3 participants