Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for dependent resources before depolying the .dacpac #380

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Jan 11, 2025

fixes #373

Closes #373

Wait for dependent resources before depolying the .dacpac

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Code follows all style conventions

Other information

@ErikEJ ErikEJ requested a review from jmezach as a code owner January 11, 2025 10:55
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Jan 11, 2025

@aaronpowell Failed Deno test seems unrelated?

@aaronpowell
Copy link
Member

Yep, I have #377 open to figure out what's up with Deno

Copy link
Contributor

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +175 to +176
var notificationService = resourceReady.Services.GetRequiredService<ResourceNotificationService>();
await notificationService.WaitForDependenciesAsync(builder.Resource, ct);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WaitForCompletion not working as (I) expected with SQL Projects
4 participants